In NOW, I have always done the full castling legality check during move generation, including the test for attacks of the to and position the king moves over. Of course, if I was more clever, I would just do the fast, simple tests during move generation, and do the more expensive attacks checks only if the move is played.
What do you all do?
Mark