Fairy-Stockfish janggi (ponder Problem)

[janggi-korea]

I have tested it several times. There are some problems.
1. When I play with the engine, if I click to "PASS" the clock, the engine does not work after that. (After opening)
2. When I click the clock and do "PASS" while using the openingbook moveing in the beginning, the engine moves incorrectly. Wrong move or stop

[H.G.Muller]

Stockfish did not understand the CECP notation for turn pass (@@@@). I have pointed that out to the developer on GitHub (in the Janggi issue). What you describe suggests that it isn't fixed yet, or that you are still using a version from before it was fixed.

[janggi-korea]

ok. I remembered. The engine developer has not officially modified it yet.
I have successfully made a book with 25000 games. It works fine. thanks.

i have some question.

1. white: How can I change the Chinese color? (piece center color) It is currently black(font). The official color is blue.

2. Currently, many janggi users are still using winboard with cecp and xaingqi variants. They have a lot of difficulty in making openingbook. Can you help me to make a janggi book in the xaiangqi variant? Currently not working.
=========================================================================
Anyway, we have no choice but to play with the xaingqi variant.
i think janggi variant needs to be considered from a more future perspective.
Perhaps you made the first cornerstone of janggi.

[H.G.Muller]

I have tried an entirely different approach to the book symmetry now, in the latest WinBoard-AA upload: For every access to a '-sym' book (both read and write, also writing to the memory buffer in which it stores positions when building a book from PGN), it decides whether the requested position is 'canonical' or a mirror image. In the latter case it calculates the key after reflection (to get the key of the canonical counterpart). And it reflects the retrieved move after reading, or the move to be written before writing. This should prevent that both members of a mirror-image pair can ever be stored in the book, and thus guarantees that all moves for the position can always be found in the single stored member of the pair. And that probing always immediately requests that stored member.

I tested it with Edit Book; if I played g3g4, there were no moves in the book. If I played c3c4, there weren't any moves either. After c3c4 I added Ke9 and Hg7 to the book. When I then took the move back, and played g3g4 instead, I found that Ke9 and Hc7 had been added for that position. I did not test it with Save Games as Book, but I expect it to work there too.

[janggi-korea]

When I tested it, there are some errors.

1. In the second move (black), the mirror motion is not applied. (All book movements have been reversed.)
2. 16.7% 1 Hh9f6 {1/0}: The movement division is unknown. (Coordinates overlap with different pieces.) A lot of similar overlapping coordinates occurred, and it indicated an error.

The important point is that there is the same symmetry, and there are different left and right symmetry. At that time, the mirrored pieces is different.
I mean the mirrors are different depending on the starting position.
It seems like a problem occurs when playing the game from the mirrored starting position.
In my opinion, mirrored movements should not affect movements already entered in the book at this time. (The coordinates change.)
Even if i start the game with a mirrored start position, it is not displayed as a converted book movement (edit book)

I have updated 16 starting positions and 25000 game book files to my Google Drive. (janggi start positions and book.zip)

Perhaps you need 16 starting positions and checking in my book. (mirror)

I ran 2 winboards to check this problem, one applied sym and the other did not. And they compared movements with each other in 16 positions. And on the blank book, I used edit to check the movement.

[H.G.Muller]

I don't understand exactly what you did. Most important thing is that we are talking about the same WinBoard version. Unfortunately I again forgot to update the version number, but the date of last modification of the winboard.exe file should be Oct 17, 22:06 (Amsterdam Time).

You don't say what position you were looking at, which book you were using, whether you just added moves yourself to it. And whether you were running WinBoard with or without engine. The move you mention is an Elephant move, but it start from h9, which nominally is a Horse square. Were you probing a position where the Horse and Elephant had been swapped, or is WinBoard now probing totally unrelated positions?

[janggi-korea]

I used the same Winboard version.

The way I explain this easily is simple.

1. Run 2 Winboards. Apply sym(book).
2. Load each symmetrical Fen file.
(If the number in front of the file I attached is the same, it is a symmetric fen file.)
3. Enter the movement using edit book.
4. And check that each winboard moves in the same symmetry.

When I checked it did make any parsing errors.
and not symmetric move. It was making the wrong move.
The book shows incorrect overlapping and incorrect move of symmetry.

[H.G.Muller]

I used the same Winboard version.

Same as what? That modified on 22:06?

The way I explain this easily is simple.

1. Run 2 Winboards. Apply sym(book).

What does "Apply" mean here, and what is "sym(book)"? Do you run them with or without engine?

2. Load each symmetrical Fen file.
(If the number in front of the file I attached is the same, it is a symmetric fen file.)

What file? Attached to what? What does "symmetric fen file" mean?

3. Enter the movement using edit book.
4. And check that each winboard moves in the same symmetry.

What does "moves" mean? You have an engine loaded, and let it play a move? Or just that it displays a move in the Edit Book window?

When I checked it did make any parsing errors.

Parsing what, and when? Did it complain a book move was illegal when it tried to play it for an engine? If you enter an illegal move during Edit Book it should just reject it, and nothing will be added to the book.

and not symmetric move. It was making the wrong move.

What does "wrong" mean here? Illegal? Did you have legality testing on?

The book shows incorrect overlapping and incorrect move of symmetry.

Which book? What does "incorrect overlapping" mean? What would be "correct overlapping"? Are you saying that moves are not correctly reflected?

[janggi-korea]

1. 2020-10-17 PM 10:06

2. use book-sym.bin and 25000 game book-sym.bin (Google Drive)
Engine use and edit mode same position error.

3. Google Drive FEN file : (0-1position,0-2position)/(1-1position,1-2position)/(2-1position,2-2position)....

4. Move = Move entered in book OR edit book move.

5. E.g 99.9% 1 Eg9f7 : Message: "could not parse move"
The same error occurs in engine loading or editing mode.

6. Wrong move: test legality doesn't matter. The problem is that the mirrored moving coordinates (book) did not change the symmetrical movement (left and right inversion).
Sorry. It is difficult to explain this accurately with my English skills. I'll explain it in a video later.

7. Incorrect duplicate coordinates: E.g 99.9% 1 Eg9f7: Message: "could not parse move"

When I enter a move in the book and check it in the mirror start position, the duplicate coordinates like this Eg9f7 are displayed in the book.

I am sorry. I have been talking to you for a long time, but I still can't speak English well

[H.G.Muller]

Well, I really must know the FENs of the positions that you used for probing the book, to be able to reproduce this. Can you please post those FENs here?

[janggi-korea]

As I said earlier, this problem is very simple.
You just need to check whether the symmetrical movements are correct.

* sample fen (2 types of starting positions)
1-1. Left : rhea1aher/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RHEA1AHER w 0 1
1-2. Right : reha1aehr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/REHA1AEHR w 0 1

2-1. Left : rhea1aehr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RHEA1AHER w 0 1
2-2.Right : rhea1aehr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/REHA1AEHR w 0 1

* check point
1.Only pieces moving vertically from the center of the board have the same coordinates.
2.At each FEN position, you must check the movement status symmetrically and accurately, and check the coordinates where different objects overlap.

[janggi-korea]

Mueller, i want to play janggi in uci mode. Currently cutechess can play janggi in uci mode. However, there is no editing function and analysis function. Could you change the janggi variant coordinates? If that officially matters, just want to get a test version.
Is it a serious problem for us to change the current coordinates? but cutechess have already changed the coordinates.

[H.G.Muller]

Sorry, I had to tend to other matters these past days.

I would rather just fix the ponder problem in Stockfish. Doesn't seem that the developer himself is interested in doing that any time soon. I posted some ideas there to solve that issue, but there is absolute zero response.

You told me you could compile Stockfish. Unfortunately I never succeeded in doing that with the compiler I have. If I would send you two or three modified cpp files, with some changes in it that I expect to solve the ponder issue, would you be willing to try those out?

[janggi-korea]

Yes. After replacing the files, i will compile and test. Please upload it to my email or Google Drive or

[H.G.Muller]

OK, I have prepared something. I needed to modify 3 source files; they are at http://hgm.nubati.net/Stockfish.zip .

If there are compiler errors, please post the error messages here. (Or, when they are trivial typos, correct them yourselves.) I hope there are none.

This was a bit difficult for me, because I had no idea how Stockfish normally works, and it is written in a programming language I am not familiar with. If it compiles, first try to run it with pondering switched off, and using the -debug option in WinBoard. I had to change what happens there too; originally the move played by Stockfish would be printed by the search routine itself (in search.cpp), when it terminated. I could not keep it that way, because then it would also print a move when you abort a ponder search. And this would confuse the GUI.

So I used a trick: at the end of the search it only sends an erroneous command to the GUI, to which WinBoard will reply with an error message. That error message is then received by the Stockfish input thread (running the code in xboard.cpp), where it is known whether Stockfish is pondering or not. And if it is not, it then sends the move to the GUI. We must first test whether this works as I intended. If it doesn't, please post the contents of the winboard.debug file that was created here.

If it does, we can start testing with pondering switched on. Sending the move Stockfish plays would then be immediately followed by starting a ponder search (which should be noticieable by the output Stockfish would produce). The question then is whether this ponder search will be terminated in a correct way when the expected move arrives, and when another move arrives.

[janggi-korea]

Solved engine file compilation problem.

[H.G.Muller]

OK, in search.cpp the // before the comment somehow got deleted. Please put it back before the [HGM]:

Code: Select all

      {   // [HGM] KLUDGE ALERT! Make GUI wake up input thread so it can process move


In xboard.cpp the sync_out indeed should have been sync_cout. Just add the c and then try again.

Code: Select all

              sync_cout << "move " << UCI::move(pos, m) << sync_endl; // print move


[janggi-korea]

thank you very much~!

Solved engine file compilation problem.

I did play winboard. And the ponder works very well. First, I'll test more. Please tell me about the important points that I should test.
And the contents of the engine debug file.
At first, the ponder was turned off. After that I ran ponder again.

>> lift a3
<< highlight 9/9/9/9/9/Y8/1Y7/9/9/9
>> put b3
>> time 30000
>> otim 30000
>> usermove a3b3
>> usermove a3b3
<< info string classical evaluation enabled
<< 1 54 0 321 1 160500 0 b9c7
<< 2 73 0 692 2 346000 0 b9c7 a0a1
<< 3 106 0 1047 3 349000 0 b9c7 a0a1 b7e7
<< 4 152 0 1334 4 444666 0 b9c7
<< 5 194 0 2982 5 745500 0 b9c7 a0a2 b7g7
<< 6 14 1 17335 6 1083437 0 i6h6 b0c2 b9c7 h0g2 h9g7 h2e2
<< 7 28 1 19537 7 1085388 0 b9c7 h0g2 h9g7 b0c2 c6d6 c3d3
<< 8 38 2 25289 9 1099521 0 b9c7 h0g2 b7e7 a0a4 h9g7 h2e2 a9a7
<< 9 42 8 87401 13 1016290 0 b9c7 h0g2 b7e7 b0c2 i6h6 h2e2 h9g7 b2b7
<< 10 28 14 133772 12 955514 0 b9c7 b0c2 h9g7 h0g2 b7e7 e1e0 g6f6 h2e2 c6d6 g3f3
<< 11 28 26 252757 16 964721 0 b9c7 h0g2 h9g7 e1e0 c6d6 d0e1 b7d7 g3f3 h7e7 b0c2
<< 12 29 29 286323 15 964050 0 b9c7 b0c2 c6d6 h0g2 i6h6 e1e0 h9g7 f0e1 b7d7 g3f3 h7e7 c3d3 d7a7 a0b0 e8d8
<< 13 29 63 609489 20 959825 0 b9c7 h0g2 h9g7 i3h3 h7e7 b0c2 c6d6 e1e0 b7d7 d0e1 e8e9 i0i1
<< 14 29 108 1047203 18 969632 0 h9g7 h0g2 b9c7 i3h3 e8e9 b0c2 h7e7 e1e0 f9e8 a0a4 e7i7 i0h0 i6h6 h2e2
<< 15 29 163 1599874 25 977918 0 h9g7 e1e0 i6h6 h0g2 b9c7 f0e1 b7d7 b0c2 e8e9 h2e2 f9e8 g3h3 c6d6 a0a4 h7e7 a4c4 c7d5 i0i1
<< 16 35 216 2125125 20 979771 0 i6h6 h0g2 b9c7 e1e0 h9g7 f0e1 b7d7 b0c2 e8e9 h2e2 d9e8 i0i1 h7h2 g3h3 d7a7 a0b0 a6b6 i1f1
<< 17 38 226 2220194 19 980651 0 i6h6 h0g2 b9c7 e1e0 h9g7 f0e1 e8e9 h2c2 b7e7 b2b7 e6d6 c2i2 i9h9 i2e2 g9e6 g3f3 d9e8 b0c2 a9a7
<< 18 30 307 3019012 20 982751 0 i6h6 h0g2
<< 18 29 323 3171461 20 981876 0 i6h6 h0g2 b9c7 e1e0 h9g7 f0e1 e8e9 b0c2 c6d6 h2e2 a6a5 g3h3 d9e8 i0i1 h7f7 e2i2 g9i6 i1f1
<< 19 29 366 3594654 19 981341 0 i6h6 h0g2 b9c7 e1e0 h9g7 f0e1 e8e9 b0c2 f9e8 h2e2 b7d7 a0a4 e6d6 b2d2 h7e7 d2f0 d7f9 g3f3 c7e6
<< 20 29 439 4291504 25 977118 0 i6h6 h0g2 b9c7 b0c2 h9g7 e1e0 e8e9 h2e2 c6d6 d0e1 d9e8 g3h3 h7e7 i0i1 i9h9 c3d3 e9d9 b2d2 b7d7 i1f1
<< 21 37 526 5127045 23 973243 0 i6h6
<< 21 35 628 6072087 24 966123 0 i6h6 h0g2 b9c7 b0c2 h9g7 e1e0 e8e9 f0e1 d9e8 g3f3 f9f8 i3i4 c6d6 a0a4 a6a5 a4c4 a5b5 b2d2 a9a0 c0a3 i9h9 d2f0
<< 22 35 890 8528056 27 958100 0 i6h6 h0g2 b9c7 b0c2 h9g7 e1e0 e8e9 f0e1 d9e8 h2e2 a9a7 e2i2 i9h9 i3h3 h7h5 i2e2 b7e7 b2d2 c6b6 d2f0
<< 23 37 1432 13407090 28 935922 0 i6h6 h0g2 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 f9e8 f0e1 h7e7 b2d2 c6d6 d2f0 d9d8 g3f3 b7d7 a0a4 a9a7 d0d1 g6f6 i3i4 d7d9 a4c4
<< feature GOTMOVE=1
>> rejected GOTMOVE
<< move i6h6
>> lift h0
<< highlight 9/9/9/9/9/9/9/6Y1Y/9/9
>> put g2
>> time 28567
>> otim 29682
>> usermove h0g2
<< info string classical evaluation enabled
<< 1 37 0 280 1 140000 0 b9c7
<< 2 37 0 650 2 325000 0 b9c7 h2e2
<< 3 37 0 1058 3 529000 0 b9c7 h2e2 h9g7
<< 4 38 0 1545 4 772500 0 b9c7 b0c2 e8e9 e1e0
<< 5 33 0 2370 5 790000 0 b9c7 b0c2 e8e9 e1e0 h9g7
<< 6 37 0 2996 6 998666 0 b9c7 b0c2 h9g7 h2f2 e8e9 f2i2
<< 7 37 0 3390 7 1130000 0 b9c7 b0c2 h9g7 h2f2 e8e9 f2i2 i9h9
<< 8 41 0 6081 9 1216200 0 b9c7 b0c2 e8e9 e3f3 b7e7 g0e3 h9g7 e1f1 e7a7
<< 9 38 0 8189 10 1637800 0 b9c7 b0c2 e8e9 e1e0 h9g7 g3f3 d9e8 f0e1 c6d6
<< 10 39 0 13130 12 1641250 0 b9c7 e1e0 h9g7 b0c2 e8e9 f0e1 d9e8 h2e2 c6d6 g3f3 a6a5
<< 11 38 0 15974 13 1774888 0 b9c7 e1e0 h9g7 b0c2 e8e9 f0e1 d9e8 g3f3 c6d6 i3i4 a6a5 h2e2 b7e7
<< 12 43 1 21645 14 1803750 0 b9c7 e1e0 h9g7 f0e1 e8e9 b0c2 d9e8 h2e2 c6d6 g3f3 a6a5 i3i4 b7e7 b2d2
<< 13 41 2 37631 19 1710500 0 b9c7 e1e0 h9g7 g3f3 e8e9 b0c2 d9e8 f0e1 c6d6 i3i4 a6a5 h2e2 b7e7
<< 14 38 2 46604 17 1664428 0 b9c7 e1e0 h9g7 f0e1 e8e9 b0c2 d9e8 g3f3 c6d6 i3i4 a6a5 h2e2 b7e7 i0i1 h7f7
<< 15 36 6 100911 21 1483985 0 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 d9e8 a0a4 e6d6 f0e1 i9i5 e3f3 h7e7 c0e3 g9e6 e3c6 d6c6
<< 16 33 15 196233 22 1291006 0 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 d9e8 a0a4 b7d7 f0e1 a9a7 b2d2 i9i5 i3i4 i5d5 g3f3 c6d6 d2f0 h7e7
<< 17 33 22 272942 22 1218491 0 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 f9e8 f0e1 h7e7 a0a4 b7d7 b2d2 d9d8 d0d1 c6d6 a4c4 a9a7 g3f3
<< 18 41 27 334044 21 1205935 0 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 d9e8 a0a4 e6d6 f0e1 g9e6 e2i2 i9g9 i3h3 f9f8 i2d2 b7e7 c3d3 e7a7 a4f4
<< 19 41 33 397289 21 1185937 0 b9c7 e1e0 h9g7 b0c2 e8e9 h2e2 d9e8 a0a4 e6d6 f0e1 g9e6 e2i2 i9g9 i3h3 f9f8 i0i1 b7f7 i2e2 f7d9 i1f1
<< 20 38 137 1448476 22 1050381 0 h9g7 e1e0 b9c7 b0c2 e8e9 h2e2 b7d7 f0e1 d9e8 a0a4 a9a7 g3f3 f9f8 b2d2 c6d6 i3i4 i9h9 a4c4 h7h2 d2f0
<< 21 36 151 1585312 22 1048486 0 h9g7 e1e0 b9c7 b0c2 e8e9 h2e2 b7d7 f0e1 d9e8 a0a4 a9a7 g3f3 f9f8 b2d2 c6d6 i3i4 i9i8 d0d1 d7f9 a4c4 h7e7
<< 22 36 459 4413779 26 960561 0 h9g7 b0c2 b9c7 e1e0 e8e9 h2e2 b7d7 f0e1 d9e8 a0a4 a9a7 g3f3 f9f8 b2d2 i9i5 a4i4 i5i4 i3i4 h7e7 d2f0 d7f9 i4i5 c6d6 i0i4
<< 23 36 523 4990742 27 952795 0 h9g7 e1e0 b9c7 b0c2 e8e9 h2e2 d9e8 a0a4 b7e7 f0e1 a9a7 i3i4 f9f8 g3f3 h7f7 d0d1 g6f6 b2d2 f7d9 d2d0 c6d6 a4c4 h6g6
<< 21 38 523 4990857 27 952635 0 h9g7 b0c2 b9c7 e1e0 e8e9 h2e2 d9e8 a0a4 b7e7 f0e1 h7f7 b2d2 i9i5 d0d1 c6d6 i3i4 i5g5 e3f3 f7d9 d2d0 a9a7 g0e3
<< feature GOTMOVE=1
>> rejected GOTMOVE
<< move h9g7
>> force
>> ping 8
<< pong 8
>> memory 4093
>> cores 12
>> new
>> random
<< Error (unknown command): random
>> variant janggi
<< setup (.N.R.AB.P..C.........K.n.r.ab.p..c.........k) 9x10+0_xiangqi rnba1abnr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RNBA1ABNR w - - 0 1
<< piece R& RB
<< piece C& pRpB
<< piece P& fsWfF
<< piece N& nN
<< piece B& mafsmafW
<< piece A& WF
<< piece K& WF
>> level 40 5 0
>> post
<< Error (unknown command): post
>> hard
>> easy
>> ping 9
<< pong 9
>> hard
>> force
>> ping 10
<< pong 10
>> memory 4093
>> cores 12
>> new
>> random
<< Error (unknown command): random
>> variant janggi
<< setup (.N.R.AB.P..C.........K.n.r.ab.p..c.........k) 9x10+0_xiangqi rnba1abnr/4k4/1c5c1/p1p1p1p1p/9/9/P1P1P1P1P/1C5C1/4K4/RNBA1ABNR w - - 0 1
<< piece R& RB
<< piece C& pRpB
<< piece P& fsWfF
<< piece N& nN
<< piece B& mafsmafW
<< piece A& WF
<< piece K& WF
>> level 40 5 0
>> post
<< Error (unknown command): post
>> hard
>> ping 11
<< pong 11
>> lift a3
<< highlight 9/9/9/9/9/Y8/1Y7/9/9/9
>> lift a0
<< highlight 9/9/9/9/9/9/9/Y8/Y8/9
>> put a1
>> time 30000
>> otim 30000
>> usermove a0a1
<< info string classical evaluation enabled
<< 1 92 0 244 1 122000 0 b9c7
<< 2 125 0 573 2 191000 0 b9c7 a1b1
<< 3 165 0 923 3 307666 0 b9c7 a1c1 b7e7
<< 4 181 0 1417 4 472333 0 b9c7 a1c1 b7e7
<< 5 171 0 5719 5 817000 0 h9g7 a3b3 b9c7 i3h3
<< 6 57 1 13781 6 1148416 0 h9g7 h0g2 b9c7 h2e2 h7e7 i0h0
<< 7 64 1 16211 7 1157928 0 h9g7 b0c2 b9c7 b2e2 b7e7 h0g2
<< 8 67 7 82846 12 1119540 0 b9c7 b0c2 h9g7 h0g2 g6h6 a3b3 h7e7
<< 9 49 7 87730 10 1110506 0 b9c7 b0c2 h9g7 h0g2 b7e7 e1e0 i6h6 d0e1 e6d6
<< 10 59 25 253872 13 1007428 0 h9g7 b0c2 b9c7 h0g2 a6b6 c3d3 e8e9 e1e0 d9e8
<< 11 51 35 358725 14 1010492 0 b9c7 b0c2 a6b6 b2e2 e8e9 c3b3 h9g7 e1e0 i6h6 h0g2 b7d7 e2a2 a9b9
<< 12 51 36 366289 12 1006288 0 b9c7 b0c2 a6b6 b2e2 e8e9 h0g2 h9g7 c3b3 i6h6 e1e0 b7d7 f0e1
<< 13 42 50 509658 16 1015254 0 b9c7 b0c2 h9g7 h0g2 e8e9 a3b3 f9e8 e1e0 b7d7 g3f3 i6h6 b2b7 c6d6 d0e1
<< 14 45 93 948518 17 1014457 0 b9c7 b0c2 h9g7 h0g2 e8e9 a3b3 f9e8 e1e0 b7d7 i3h3 c6d6 b2b7 h7e7 h2e2
<< 15 48 126 1263976 17 999981 0 b9c7 b0c2 h9g7 h0g2 e8e9 a3b3 f9e8 e1e0 b7d7 i3h3 c6d6 b2b7 h7e7 h2e2 e7i7 e2a2
<< 16 51 183 1825956 20 995071 0 a6b6 b0c2 b9c7 h0g2 e8e9 b2e2 h9g7 i3h3 h7e7 e1e0 d9e8 f0e1 b7b2 a1b1 b2b8 c3b3 g6h6 g3f3
<< 17 48 296 2909546 21 982954 0 b9c7 a3b3 i6h6 h0g2 h9g7 b0c2 c6d6 g3f3 e8e9 e1e0 d9e8 h2e2 b7e7 i0i2 h7f7 d0e1 f7d9 b2b7
<< 18 56 450 4348238 24 965845 0 a6b6
<< 18 59 502 4813829 24 957975 0 a6b6 b0c2 i6h6 e1e0 b9c7 h0g2 e8e9 h2e2 h9g7 d0e1 d9e8 g3h3 g6f6 c3d3 h7e7 i0i1 a9a5 e2i2 g9i6 i1h1 a5g5 h1f1
<< 19 51 605 5803953 23 958064 0 a6b6 b0c2
<< 19 50 630 6045801 26 959194 0 a6b6 i3h3 h9g7 h0g2 e8e9 b0c2 f9e8 b2e2 b9c7 e1e0 g6f6 e2a2 a9b9 c3b3 b7d7 g3f3 h7e7 d0e1 c6d6 i0i4 d7d5 h2h7 i9i7
<< 20 51 647 6216987 23 959707 0 a6b6 i3h3 h9g7 h0g2 e8e9 b0c2 f9e8 i0i1 b9c7 e1e0 h7e7 b2e2 a9a5 a3b3 a5a1 i1a1 i6h6 d0e1 i9i0 a1a9 i0g0 a9c9
<< 21 47 762 7313879 28 959700 0 a6b6 i3h3 h9g7 h0g2 e8e9 b0c2 b9c7 e1e0 h7e7 b2e2 f9e8 i0i1 b7b2 c3d3 g6f6 f0e1 a9a5 a1a2 b2b8 i1f1 a5c5
<< 22 55 795 7633178 7 959424 0 a6b6
<< 22 57 840 8052506 27 958403 0 a6b6 i3h3 h9g7 h0g2 h7e7 e1e0 b9c7 i0i1 e8e9 b0c2 f9e8 b2e2 b7d7 d0e1 a9a5 h2f2 g6f6 a1a2 d9d8 c3d3 d7d9
<< 23 49 1018 9719032 34 954530 0 a6b6 i3h3
<< 23 57 1046 9966219 34 952429 0 a6b6
<< 23 54 1047 9980078 34 952388 0 a6b6 i3h3 h9g7 h0g2 h7c7 e3d3 c7i7 h2e2 e8f8 e2i2 b9c7 b0c2 i6h6 c2e3 f9e8 e1e0 i7f7 g0i3 i9h9 b2h2 g6f6 h2h4
<< 24 46 1314 12489690 29 950147 0 a6b6 i3h3
<< 24 47 1405 13335373 33 949136 0 a6b6 i3h3 h9g7 h0g2 b9c7 b0c2 e8e9 e1e0 h7e7 b2e2 f9e8 d0e1 b7d7 e2a2 a9b9 c3d3 d9d8 e1e2 b9b8 a1f1 g6f6 f0e1 d7f9 h2f2
<< feature GOTMOVE=1
>> rejected GOTMOVE
<< move a6b6
<< info string classical evaluation enabled
<< 1 49 0 380 1 380000 0 h9g7
<< 2 49 0 696 2 696000 0 h9g7 h0g2
<< 3 49 0 1041 3 1041000 0 h9g7 b0c2 h7c7
<< 4 49 0 1390 4 695000 0 h9g7 b0c2 h7c7 b2e2
<< 5 49 0 1945 5 972500 0 h9g7 b0c2 h7c7 b2e2 c7i7
<< 6 52 0 2714 7 1357000 0 h9g7 h0g2 h7c7 e3d3 c7i7 h2e2 e8f8
<< 7 56 0 4018 8 1339333 0 h9g7 b0c2 h7c7 b2e2 c7i7 h0i2 b9c7
<< 8 56 0 4831 8 1610333 0 h9g7 b0c2 h7c7 b2e2 c7i7 h0i2 b9c7 h2h7
<< 9 57 0 6708 10 1677000 0 h9g7 b0c2 h7c7 b2e2 c7i7 h0i2 b9c7 h2h7 b7e7 e1e0
<< 10 45 0 10986 13 1831000 0 h9g7 h0g2 h7c7 e3d3 c7i7 h2e2 e8f8 e2i2 b9c7 e1e0 a9a5 b0c2
<< 11 45 1 18890 12 1574166 0 h9g7 h0g2 e8e9 b0c2 b9c7 b2d2 f9e8 h2e2 g6f6 i0i4 h7h2 e1e0
<< 12 45 1 23800 13 1586666 0 h9g7 h0g2 h7c7 e3d3 c7i7 h2e2 e8f8 e2i2 b9c7 e1e0 a9a5 b0c2 d9e8
<< 13 45 3 56657 15 1666382 0 h9g7 h0g2 h7c7 e3d3 c7i7 h2e2 e8f8 e2i2 i6h6 b0c2 b9c7 e1e0 i7f7 g0i3 i9h9
<< 14 47 4 82101 18 1675530 0 h9g7 h0g2 e8e9 b0c2 b9c7 e1e0 f9e8 b2e2 h7e7 d0e1 d9d8 i0i4 b7d7 e3d3 a9a5 c2e3 a5i5
<< 15 47 5 86451 18 1662519 0 h9g7 h0g2 e8e9 b0c2 b9c7 e1e0 f9e8 b2e2 h7e7 d0e1 d9d8 c3d3 b7d7 e2a2 c9a6 h2e2 g6f6 i0i4
<< 16 50 12 174880 19 1366250 0 h9g7 h0g2 e8e9 b0c2 f9e8 b2e2 b9c7 e1e0 h7e7 d0e1 d9d8 h2f2 b7d7 c3d3 a9a5 f2i2 i6h6 g0i3 i9h9
<< 17 50 13 178778 19 1354378 0 h9g7 h0g2 e8e9 b0c2 f9e8 b2e2 b9c7 e1e0 h7e7 d0e1 d9d8 h2f2 b7d7 c3d3 a9a5 f2i2 i6h6 g0i3 i9h9
<< 18 45 23 288903 23 1229374 0 h9g7 h0g2 e8e9 b0c2 f9e8 b2e2 b9c7 e1e0 h7e7 d0e1 d9d8 e3d3 i9i7 g0e3 g6f6 h2f2 b7d7 e2a2 a9b9
<< 19 44 37 432066 21 1158353 0 h9g7 h0g2 e8e9 b0c2 h7e7 e1e0 f9e8 b2e2 b9c7 d0e1 d9d8 e2a2 a9b9 c3d3 b7d7 a2e2 g6f6 h2f2 d7f9
<< 20 47 98 1029607 24 1047413 0 h9g7 h0g2 e8e9 b0c2 b9c7 e1e0 h7e7 d0e1 f9e8 e1e2 g6h6 c3d3 d9d8 h2f2 a9a5 g3f3 a5c5 i0i4 b7b5 i4g4
>> lift h0
<< highlight 9/9/9/9/9/9/9/9/9/9
<< 21 44 445 4270428 26 959000 0 h9g7 h0g2 e8e9 b0c2 b9c7 e1e0 f9e8 d0e1 d9d8 i0i4 h7f7 b2e2 f7d9 h2f2 a9a5 f2d0 b7e7 f0f1 i9i7 e3d3 g6f6
<< 22 47 721 6820287 25 945554 0 h9g7 h0g2 e8e9 b0c2 f9e8 b2e2 b9c7 e1e0 h7f7 d0e1 b7e7 a3a4 d9d8 i0i4 i9i8 h2f2 i8f8 g3f3 e6f6 f2d0 i6h6 c3d3
<< 23 55 1205 11239568 28 932202 0 h9g7
>> put g2
>> time 28594
>> otim 28773
>> usermove h0g2
<< 23 55 1226 11430562 28 931889 0 h9g7
<< feature GOTMOVE=1
<< info string classical evaluation enabled
<< 1 67 0 332 1 166000 0 i6h6
<< 2 67 0 668 2 334000 0 i6h6 g3f3
<< 3 67 0 1043 3 521500 0 i6h6 g3f3 h9g7
<< 4 67 0 1511 4 755500 0 i6h6 g3f3 h9g7 b0c2
<< 5 67 0 2080 5 1040000 0 i6h6 g3f3 h9g7 b0c2 a9a5
<< 6 67 0 2836 6 945333 0 i6h6 g3f3 b9c7 b0c2 h9g7 h2e2
<< 7 67 0 3633 7 1211000 0 i6h6 g3f3 b9c7 b0c2 e8e9 b2e2 a9a5
<< 8 65 0 5112 8 1278000 0 i6h6 g3f3 h9g7 b0c2 a9a5 i0i1 h7e7 b2e2
<< 9 64 0 8354 9 1670800 0 i6h6 g3f3 h9g7 b0c2 a9a5 i0i1 e8e9 b2e2 b9c7
<< 10 67 0 12782 11 1597750 0 i6h6 g3f3 h9g7 b0c2 a9a5 e1e0 b9c7 d0e1 e8e9 i3i4 d9e8
<< 11 67 0 15187 12 1687444 0 i6h6 b0c2 e8e9 g3f3 b9c7 b2e2 h9g7 e2a2 a9b9 c3b3 i9i5 h2e2
<< 12 67 1 17897 12 1789700 0 i6h6 b0c2 e8e9 g3f3 b9c7 b2e2 h9g7 e2a2 a9b9 c3b3 i9i5 h2e2
<< 13 67 1 21514 13 1654923 0 i6h6 b0c2 e8e9 g3f3 b9c7 b2e2 f9e8 e2a2 a9b9 c3b3 b7g7 g2f4 c6d6
<< 14 67 3 55090 14 1449736 0 i6h6 b0c2 e8e9 g3f3 f9e8 b2e2 b9c7 e2a2 a9b9 h2e2 h9g7 c3b3 h7h2 g2f4
>> rejected GOTMOVE
<< 15 65 44 458962 20 1043095 0 i6h6 b0c2 e8e9 e1e0 b9c7 h2e2 h9g7 d0e1 d9e8 f0f1 i9i5 b2d2 b7e7 d2f0 g6f6 i3h3 i5i0 f0i0
<< 16 63 53 555983 22 1037281 0 i6h6 b0c2 e8e9 e1e0 b9c7 d0e1 h9g7 h2e2 d9e8 f0f1 a9a5 e2i2 i9h9 i3h3 h7h5 i2e2 h5h2
<< 17 55 64 666893 21 1030746 0 i6h6 b0c2 e8e9 e1e0 b9c7 d0e1 h9g7 h2e2 i9i5 b2d2 d9e8 f0f1 g6f6 a1d1 i5g5 i3h3 h7h3 g3h3 g5g2
<< 18 53 150 1518907 24 1012604 0 i6h6 h2e2 h9g7 b0c2 e8e9 e1e0 b9c7 d0e1 f9e8 i0i1 h7h2 b2d2 c6d6 i1h1 h2h8 g3h3 b7e7 a1d1 h8d8 c3b3 g6f6 h1f1
<< 19 50 202 2042048 25 1009914 0 i6h6 h2e2 h9g7 b0c2 b9c7 e1e0 e8e9 d0e1 f9e8 b2d2 c6d6 f0f1 h7e7 d2a2 a9b9 a3b3 b9b8 e2i2 e7i7
<< 20 55 421 4172730 30 990441 0 i6h6 h2e2 h9g7 b0c2 e8e9 b2d2 a9a5 e1e0 f9e8 d0e1 b9c7 f0f1 b7e7 d2f0 a5c5 a3b3 c9a6 e2i2 i9h9 i3h3 h7h5 a1d1
<< feature GOTMOVE=1
>> rejected GOTMOVE
<< move i6h6
<< info string classical evaluation enabled
<< 1 55 0 272 1 272000 0 h9g7
<< 2 55 0 699 2 699000 0 h9g7 b0c2
<< 3 55 0 1129 3 1129000 0 h9g7 b0c2 b9c7
<< 4 59 0 1618 4 809000 0 h9g7 b0c2 b9c7 e1e0
<< 5 55 0 2232 5 1116000 0 h9g7 b0c2 e8e9 b2d2 a9a5
<< 6 55 0 2847 6 1423500 0 h9g7 b0c2 e8e9 b2d2 a9a5 e1e0
<< 7 55 0 3434 7 1717000 0 h9g7 b0c2 e8e9 b2d2 a9a5 e1e0 f9e8
<< 8 55 0 4574 9 1524666 0 h9g7 b0c2 e8e9 b2d2 a9a5 e1e0 f9e8 d0e1 b9c7
<< 9 55 0 5687 10 1421750 0 h9g7 b0c2 e8e9 e1e0 b9c7 b2d2 f9e8 d0e1 a9a5 f0f1
<< 10 54 0 7414 11 1853500 0 h9g7 b0c2 e8e9 e1e0 b9c7 b2d2 f9e8 d2a2 a9b9 d0e1 i9i5
<< 11 54 0 8699 11 1739800 0 h9g7 b0c2 e8e9 e1e0 b9c7 b2d2 f9e8 d2a2 a9b9 d0e1 i9i5
<< 12 53 2 36794 12 1599739 0 h9g7 b0c2 e8e9 e1e0 b9c7 b2d2 f9e8 d2a2 a9b9 d0e1 i9i5 a3b3
<< 13 56 2 41778 16 1606846 0 h9g7 b0c2 e8e9 e1e0 b9c7 b2d2 f9e8 d2a2 a9b9 a3b3 e6d6 g3h3 g9e6 f0e1 i9i5 e3d3
<< 14 50 7 98746 20 1299289 0 h9g7 e1e0 e8e9 b0c2 b9c7 d0e1 f9e8 b2d2 a9a5 f0f1 e6d6 e3d3 h7e7 g2e3 a5g5 g3h3 b7b2 d2f0
<< 15 50 9 116983 22 1271554 0 h9g7 e1e0 e8e9 b0c2 b9c7 d0e1 f9e8 b2d2 a9a5 f0f1 e6d6 a3b3 a5a1 c2a1 c9e6 g3g4 b7d7 a1c2 h7e7 d2f0
<< 16 44 18 201959 23 1097603 0 h9g7 e1e0 e8e9 b0c2 b9c7 d0e1 d9e8 b2d2 i9i5 d2a2 a9b9 a3b3 c6d6 a2a0 b7e7 f0f1 h7h2 a0d0
<< 17 55 25 271469 20 1085876 0 h9g7 b0c2 b9c7 e1e0 e8e9 d0e1 f9e8 b2d2 i9i5 d2a2 a9b9 a3b3 e6d6 a2a0 g9e6 g3h3 h7e7 f0f1 e6c3
<< 18 55 33 354189 23 1063630 0 h9g7 b0c2 b9c7 e1e0 e8e9 d0e1 f9e8 b2d2 i9i5 d2a2 a9b9 a3b3 e6d6 a2a0 g9e6 g3h3 h7e7 f0f1 e6c3 b3c3
<< 19 50 150 1514718 26 1007796 0 h9g7 b0c2 e8e9 b2d2 b9c7 e1e0 f9e8 d2a2 a9b9 a3b3 b7d7 i0i1 h7e7 a2a0 g6f6 d0e1 d7f9 g3f3 i9i5 i1f1 i5g5
<< 20 50 192 1930514 26 1002343 0 h9g7 b0c2 e8e9 b2d2 b9c7 e1e0 f9e8 d2a2 a9b9 a3b3 b7d7 d0e1 i9i5 i0i1 d9d8 i1f1 g6f6 a2a0 d7d9 e3d3 h7e7
>> lift h2
<< highlight 9/9/9/9/9/9/9/9/9/9
>> put e2
>> time 28173
>> otim 28463
>> usermove h2e2
<< 21 55 477 4667335 30 977861 0 h9g7 b0c2 e8e9 b2d2 b9c7 e1e0 a9a5 d0e1 f9e8 f0f1 a5g5 e3f3 h7e7 d2f0 b7d7 a3b3 c9a6 g2e3 e6d6 i3h3 i9i0 f0i0 g9e6
<< feature GOTMOVE=1
>> rejected GOTMOVE
<< move h9g7
<< info string classical evaluation enabled
<< 1 55 0 284 1 284000 0 e8e9
<< 2 55 0 568 2 284000 0 e8e9 e1e0
<< 3 55 0 1113 3 556500 0 e8e9 e1e0 b9c7
<< 4 59 0 1849 4 924500 0 e8e9 e1e0 f9e8 i0i1 b9c7
<< 5 54 0 3225 5 1075000 0 b9c7 b2d2 b7e7 e1e0 g6g5
<< 6 55 0 3714 6 1238000 0 b9c7 b2d2 a9a5 e1e0 b7e7 d0e1
<< 7 55 0 4450 7 1483333 0 b9c7 b2d2 a9a5 e1e0 b7e7 d0e1 a5g5
<< 8 55 0 6335 8 1583750 0 b9c7 b2d2 a9a5 e1e0 b7e7 d0e1 a5g5 e3f3
<< 9 55 0 9433 9 1572166 0 b9c7 e1e0 e8e9 d0e1 f9e8 b2d2 h7e7 c3b3 a9a5
<< 10 51 0 14662 13 1832750 0 e8e9 b2d2 b9c7 e1e0 d9e8 d0e1 c6d6 f0f1 a9a5 d2a2 a5c5 a2a9 c7d9
<< 11 51 1 19386 13 1762363 0 e8e9 b2d2 b9c7 e1e0 d9e8 d0e1 c6d6 f0f1 a9a5 d2f0 g6f6
<< 12 50 2 40301 19 1679208 0 e8e9 b2d2 b9c7 e1e0 d9e8 d0e1 c6d6 f0f1 a9a5 d2f0 g6f6 i3h3 i9i0 f0i0 h7e7 i0f0 b7b2 c3d3
<< 13 50 2 44004 15 1629777 0 e8e9 b2d2 b9c7 e1e0 d9e8 d0e1 c6d6 f0f1 a9a5 d2f0 g6f6 i3h3 i9i0 f0i0 h7e7
<< 14 49 6 96844 20 1467333 0 e8e9 b2d2 b9c7 e1e0 f9e8 d2a2 a9b9 i0i1 h7e7 i3h3 i9i1 a1i1 g9i6 d0d1 g6f6 c3d3 b9b8 f0e1
<< 15 45 20 236773 24 1132885 0 e8e9 e1e0 b9c7 i0i1 f9e8 a3b3 a9a1 i1a1 b7e7 e2i2 i9h9 g3f3 e6d6 b2e2 g9e6 d0e1 c9a6 c3d3 h7h2 a1b1 g6f6
<< 16 52 40 417955 27 1044887 0 e8e9 e1e0 f9e8 i0i1 b9c7 a3b3 a9a1 i1a1 b7e7 e2i2 i9h9 g3f3 g6g5 b2e2 h6h5 i2f2 h9h8 a1a9 c9a6 f0e1 h7h2
<< 17 46 59 602168 26 1015460 0 e8e9 e1e0 f9e8 i0i1 b9c7 a3b3 a9a1 i1a1 b7d7 e2i2 i9h9 g3f3 e6d6 i2f2 g9e6 f0e1 c9a6 b2e2
<< 18 55 87 868079 26 997791 0 b9c7 e1e0 e8e9 d0e1 f9e8 b2d2 h7e7 d2a2 a9b9 a3b3 b7d7 a2d2 d9d8 f0f1 d7d9 d2f0 c9a6
<< 19 61 391 3797295 29 971175 0 e8e9 e1e0 b9c7 b2d2 a9a5 e2i2 i9h9 i3h3 f9e8 i2e2 h7e7 d0e1 g9i6 a3b3 a5a1 c2a1 e7i7 i0h0 g6f6 a1c2 b7e7
<< 20 53 434 4202829 27 967947 0 e8e9 e1e0
>> force
<< 20 51 522 5034422 27 963894 0 e8e9 e1e0 b9c7 b2d2 a9a5 f0f1 f9e8 d0e1 h7e7 a3b3 a5a1 c2a1 d9d8 a1c2 b7d7 d2f0 i9i5 i3h3 i5g5 f0d2 d7d9 d2f0 g6f6 i0i9
>> lift e3
<< highlight 9/9/9/9/9/9/9/9/9/9
<< 21 58 902 8570868 29 949996 0 e8e9 e1e0 f9e8 b2d2 b9c7 d2a2 a9b9 d0e1 h7e7 f0f1 b7d7 a3b3 c6d6 a2a0 c9a6 c3d3 i9i5 b3c3 a6c3 d3c3 i5c5 e3d3
>> put d3
>> usermove e3d3
<< 22 58 929 8827334 29 949584 0 e8e9 e1e0 f9e8 b2d2 b9c7 d2a2 a9b9 d0e1 h7e7 f0f1 b7d7 a3b3 c6d6 a2a0 c9a6 c3d3 i9i5 b3c3 a6c3 d3c3 i5c5 e3d3
<< feature GOTMOVE=1
>> rejected GOTMOVE
>> lift e6
<< highlight 9/9/9/3Y1Y3/9/9/9/9/9/9
>> put f6
>> usermove e6f6

[H.G.Muller]

Well, it seems that things run as I intended them to, and that you tested all important cases: the first move you played with pondering on was a ponder miss (you played h0g2, and the engine was expecting i3h3 in reply to its own a6b6). Your second move (h2e2) was a ponder hit.

I see one flaw: the current version does not tell the GUI which move it is pondering on. There are two ways a CECP engine can do this. One way is to write the ponder move in parentheses before every PV it prints, but Stockfish of course doesn't do that, as in UCI this is not done. So we have to use the second method, sending a Hint command. To make that work, can you add the line

Code: Select all

                  sync_cout << "Hint: " << ponderMove << sync_endl;   // print it


in xboard.c, immediately after the line

Code: Select all

                  ponderMove = UCI::move(pos, m);                     // remember it (indicates we are pondering)


so that the total code looks like

Code: Select all

              if(Options["Ponder"] &&
                 (Threads.main()->bestThread->rootMoves[0].pv.size() > 1 ||
                  Threads.main()->bestThread->rootMoves[0].extract_ponder_from_tt(pos)))
              {
                  m = Threads.main()->bestThread->rootMoves[0].pv[1]; // ponder move
                  ponderMove = UCI::move(pos, m);                     // remember it (indicates we are pondering)
                  sync_cout << "Hint: " << ponderMove << sync_endl;   // print it
                  do_move(pos, moveList, states, m);                  // perform it
                  limits.startTime = now(); // As early as possible!
                  Threads.start_thinking(pos, states, limits, true);  // and start pondering
              }


BTW, I see from the debug log that you still are using a Stockfish version that uses xiangqi as a parent variant.

How about this turn-pass issue? Should I fix that too? Fixing Stockfish ourselves is a lot less work than trying to convince its developers to do it...

After we are done with Stockfish I can turn back to the book problem. If you discover any glitches, let me know.

[Edit] To solve the turn-pass problem you should change the line

return "pass";

in uci.cpp to

return "@@@@";

[Edit2] Something I only noticed now: it seems that Stockfish does not highlight any squares when it is pondering and you select a piece for moving: it sends a 'highlight' command with an empty color FEN. Doesn't WinBoard complain that the move you try to make is illegal? Or do you have legality testing switched off?

[janggi-korea]

I tested both the xaingqi variant and the janggi variant.

1. In the xaingqi variant, the movable yellow circle of the piece is not displayed. Regardless of "test legality", it is not displayed.
(but janggi variant is displayed.)

2. If i uncheck "test legality" in the janggi variant, engine not work and i can not play the game.

3. The turn "pass" clicking the clock is not working. The game stop when I click the clock. The alt+i =pass command also does not run the engine.

This was tested before applying the code above.

I'll apply the code above and test again. (ponderhit)